Skip to content

fix: sort feed by newest, remove relevance scoring #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremylongshore merged 1 commit into from
Feb 16, 2026
Merged

fix: sort feed by newest, remove relevance scoring #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 9 additions & 189 deletions dashboard/src/pages/Articles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Card, CardContent } from '@/components/ui/card'
import { Badge } from '@/components/ui/badge'
import { Skeleton, SkeletonArticle } from '@/components/ui/skeleton'
import { EmptyState, NewspaperIcon } from '@/components/EmptyState'
import { getRelevanceColor, getCategoryColor } from '@/lib/design-tokens'
import { getCategoryColor } from '@/lib/design-tokens'
import IngestionButton from '../components/IngestionButton'

interface Article {
Expand All @@ -21,7 +21,6 @@ interface Article {
published_at: string
relevance_score: number
hn_points?: number
trending_score?: number
}

interface HNStory {
Expand All @@ -32,16 +31,6 @@ interface HNStory {
descendants: number
}

function calculateTrendingScore(article: Article): number {
const now = new Date()
const published = new Date(article.published_at)
const hoursAgo = (now.getTime() - published.getTime()) / (1000 * 60 * 60)
const recencyBoost = Math.max(0, 5 - (hoursAgo / 5))
const baseScore = article.relevance_score || 0
const hnBoost = article.hn_points ? Math.min(5, article.hn_points / 100) : 0
return baseScore + recencyBoost + hnBoost
}

async function fetchHNTopStories(): Promise<Map<string, HNStory>> {
const urlToStory = new Map<string, HNStory>()
try {
Expand Down Expand Up @@ -77,121 +66,6 @@ const CATEGORIES = [
{ id: 'world', name: 'World' },
]

// Trending section component
function TrendingSection({
articles,
onArticleClick
}: {
articles: Article[]
onArticleClick: (url: string) => void
}) {
const trendingByCategory = articles.reduce((acc, article) => {
const cat = article.category || 'other'
if (!acc[cat]) acc[cat] = []
acc[cat].push(article)
return acc
}, {} as Record<string, Article[]>)

Object.keys(trendingByCategory).forEach(cat => {
trendingByCategory[cat] = trendingByCategory[cat]
.sort((a, b) => (b.trending_score || 0) - (a.trending_score || 0))
.slice(0, 3)
})

const sortedCategories = Object.entries(trendingByCategory)
.filter(([_, articles]) => articles.length > 0)
.sort((a, b) => {
const maxA = Math.max(...a[1].map(x => x.trending_score || 0))
const maxB = Math.max(...b[1].map(x => x.trending_score || 0))
return maxB - maxA
})
.slice(0, 4)

const categoryNames: Record<string, string> = {
'tech': 'Tech',
'hn-popular': 'HN Blogs',
'saas_dev': 'SaaS/Dev',
'engineering': 'Engineering',
'infrastructure': 'Infra',
'science': 'Science',
'crypto': 'Crypto',
'sports': 'Sports',
'automotive': 'Auto',
'world': 'World',
}

if (sortedCategories.length === 0) return null

return (
<motion.div
initial={{ opacity: 0, y: 10 }}
animate={{ opacity: 1, y: 0 }}
className="mb-8"
>
<div className="flex items-center gap-2 mb-4">
<span className="text-xl">🔥</span>
<h2 className="text-lg font-semibold text-foreground">Trending Now</h2>
</div>

<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-4 gap-4">
{sortedCategories.map(([category, categoryArticles], idx) => (
<motion.div
key={category}
initial={{ opacity: 0, y: 10 }}
animate={{ opacity: 1, y: 0 }}
transition={{ delay: idx * 0.05 }}
>
<Card className="h-full border-l-4 border-l-primary/50">
<CardContent className="p-4">
<h3 className="font-medium text-muted-foreground text-sm mb-3">
{categoryNames[category] || category}
</h3>
<div className="space-y-3">
{categoryArticles.map((article, articleIdx) => (
<a
key={article.id}
href={article.url}
target="_blank"
rel="noopener noreferrer"
onClick={(e) => {
e.preventDefault()
onArticleClick(article.url)
window.open(article.url, '_blank')
}}
className="block group"
>
<div className="flex items-start gap-2">
<span className="text-muted-foreground text-sm font-medium w-4 tabular-nums">
{articleIdx + 1}
</span>
<div className="flex-1 min-w-0">
<p className="text-sm text-foreground group-hover:text-primary line-clamp-2 leading-snug transition-colors">
{article.title}
</p>
<div className="flex items-center gap-2 mt-1">
{article.hn_points && (
<span className="text-xs text-orange-500 dark:text-orange-400 font-medium tabular-nums">
▲ {article.hn_points}
</span>
)}
<span className="text-xs text-muted-foreground tabular-nums">
{Math.round(article.trending_score || 0)} pts
</span>
</div>
</div>
</div>
</a>
))}
</div>
</CardContent>
</Card>
</motion.div>
))}
</div>
</motion.div>
)
}

function formatTimeAgo(dateString: string): string {
const date = new Date(dateString)
const now = new Date()
Expand All @@ -217,9 +91,9 @@ function ArticleCard({ article, expanded, onToggle }: {
className="border-b border-border py-4 last:border-0"
>
<div className="flex items-start gap-3">
{/* Score indicator */}
<div className={`w-8 h-8 rounded-lg flex items-center justify-center text-xs font-semibold shrink-0 ${getRelevanceColor(article.relevance_score)}`}>
{article.relevance_score}
{/* Time indicator */}
<div className="w-auto px-2 h-8 rounded-lg flex items-center justify-center text-xs font-medium shrink-0 bg-muted text-muted-foreground tabular-nums">
{formatTimeAgo(article.published_at)}
</div>
Comment on lines +94 to 97
Copy link

@greptile-apps greptile-apps bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate time-ago display

formatTimeAgo(article.published_at) is now rendered twice per card: once here in the new time indicator badge, and again on line 116 in the source metadata row. Previously the badge showed the relevance score, so they were distinct. Now both positions display the same value, which is visually redundant.

Consider removing one of the two instances — either this badge or the inline text on line 116.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +94 to 97
Copy link

@qodo-code-review qodo-code-review bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. formattimeago() lacks date validation 📘 Rule violation ⛯ Reliability

The new time-ago badge calls formatTimeAgo(article.published_at) without handling missing/invalid
dates, which can render Invalid Date or misleading values. This violates the requirement to
explicitly handle null/empty/boundary cases for user-visible behavior.
Agent Prompt 
## Issue description
The newly added time-ago badge calls `formatTimeAgo(article.published_at)` for every article, but `formatTimeAgo()` does not handle invalid/missing timestamps (e.g., `undefined`, empty string, unparsable strings) and can display `Invalid Date`, `NaN`, or negative time values.

## Issue Context
Articles are hydrated from Firestore via `doc.data()` and cast to `Article` without runtime validation, so `published_at` may be absent or malformed in some documents.

## Fix Focus Areas
- dashboard/src/pages/Articles.tsx[69-81]
- dashboard/src/pages/Articles.tsx[94-97]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


<div className="flex-1 min-w-0">
Expand Down Expand Up @@ -336,52 +210,23 @@ function ArticlesSkeleton() {

export default function Articles() {
const [articles, setArticles] = useState<Article[]>([])
const [allArticles, setAllArticles] = useState<Article[]>([])
const [loading, setLoading] = useState(true)
const [error, setError] = useState<string | null>(null)
const [selectedCategory, setSelectedCategory] = useState('all')
const [expandedId, setExpandedId] = useState<string | null>(null)
const [hnStories, setHnStories] = useState<Map<string, HNStory>>(new Map())
const [refreshKey, setRefreshKey] = useState(0)

useEffect(() => {
fetchHNTopStories().then(setHnStories)
}, [])

useEffect(() => {
const fetchAllArticles = async () => {
try {
const articlesRef = collection(db, 'articles')
const q = query(
articlesRef,
orderBy('relevance_score', 'desc'),
orderBy('published_at', 'desc'),
limit(200)
)
const snapshot = await getDocs(q)
const fetched: Article[] = []
snapshot.forEach((doc) => {
fetched.push({ id: doc.id, ...doc.data() } as Article)
})
setAllArticles(fetched)
} catch (err) {
console.error('Error fetching all articles:', err)
}
}
fetchAllArticles()
const handler = () => setRefreshKey(k => k + 1)
window.addEventListener('ingestion-complete', handler)
return () => window.removeEventListener('ingestion-complete', handler)
}, [])
Comment on lines 224 to 228
Copy link

@gemini-code-assist gemini-code-assist bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a string literal for the event name 'ingestion-complete' is brittle because it's duplicated in IngestionButton.tsx. This could lead to silent failures if the string is changed in one file but not the other.

To improve maintainability and prevent potential bugs, I recommend defining this event name as a shared constant. For example, you could create a file like src/lib/events.ts:

// src/lib/events.ts
export const INGESTION_COMPLETE_EVENT = 'ingestion-complete';

Then, import and use this constant in both Articles.tsx and IngestionButton.tsx.

While window events are simple for this use case, for future enhancements, consider using a more structured approach for cross-component communication, such as React Context, to make dependencies more explicit.


const articlesWithTrending = allArticles.map(article => {
const hnStory = hnStories.get(article.url)
const articleWithHN = {
...article,
hn_points: hnStory?.score,
}
return {
...articleWithHN,
trending_score: calculateTrendingScore(articleWithHN)
}
})

useEffect(() => {
const fetchArticles = async () => {
setLoading(true)
Expand All @@ -394,7 +239,6 @@ export default function Articles() {
if (selectedCategory === 'all') {
q = query(
articlesRef,
orderBy('relevance_score', 'desc'),
orderBy('published_at', 'desc'),
limit(100)
)
Expand All @@ -417,7 +261,6 @@ export default function Articles() {
if (hnStory) {
article.hn_points = hnStory.score
}
article.trending_score = calculateTrendingScore(article)
fetchedArticles.push(article)
})

Expand All @@ -431,7 +274,7 @@ export default function Articles() {
}

fetchArticles()
}, [selectedCategory, hnStories])
}, [selectedCategory, hnStories, refreshKey])

const groupedArticles = articles.reduce((acc, article) => {
const cat = article.category || 'other'
Expand Down Expand Up @@ -464,31 +307,8 @@ export default function Articles() {
<IngestionButton />
</div>

{/* Score Legend */}
<div className="mt-4 flex flex-wrap items-center gap-4 text-xs text-muted-foreground">
<span className="flex items-center gap-1.5">
<span className="w-5 h-5 rounded bg-primary/15 text-primary text-[10px] font-semibold flex items-center justify-center">7</span>
Relevance (1-10, AI-scored)
</span>
<span className="flex items-center gap-1.5">
<span className="text-orange-500 font-medium">&#9650; 42</span>
HN upvotes (live)
</span>
<span className="flex items-center gap-1.5">
<span className="font-medium tabular-nums">12 pts</span>
Trending (relevance + recency + HN)
</span>
</div>
</motion.div>

{/* Trending Section */}
{!loading && articlesWithTrending.length > 0 && (
<TrendingSection
articles={articlesWithTrending}
onArticleClick={(url) => console.log('Clicked:', url)}
/>
)}

{/* Category filters */}
<div className="sticky top-16 bg-background/95 backdrop-blur supports-[backdrop-filter]:bg-background/60 py-3 z-10 border-b border-border mb-6 -mx-4 px-4">
{/* Featured: HN Popular Blogs */}
Expand Down
17 changes: 1 addition & 16 deletions firestore.indexes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,5 @@
{
"indexes": [
Comment on lines 1 to 2
Copy link

@greptile-apps greptile-apps bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing index test will break

Removing the (relevance_score DESC, published_at DESC) composite index here is correct for the new query, but tests/firebase/test_firestore_indexes.py:112 — test_articles_relevance_published_index — still asserts this index must exist in the file. That test will fail after this change.

Either remove or update the test in test_firestore_indexes.py to match the new index set.

{
Copy link

@qodo-code-review qodo-code-review bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Firestore index docs outdated 📘 Rule violation ✧ Quality

This PR removes the articles(relevance_score DESC, published_at DESC) composite index but does not
update STATUS.md and the Firestore schema/operator docs to reflect the new index expectations.
This breaks the requirement to document noteworthy configuration/operational changes.
Agent Prompt 
## Issue description
The Firestore index configuration changed (relevance-based composite index removed), but repository operational documentation was not updated. This makes operator guidance and schema/index expectations inaccurate.

## Issue Context
`firestore.indexes.json` is the source of truth for deployed composite indexes. `000-docs/001-AT-ARCH-firestore-schema.md` currently documents a relevance-based composite index and field names that no longer match the actual index configuration. `STATUS.md` also lacks a note about index deployment expectations.

## Fix Focus Areas
- firestore.indexes.json[1-47]
- 000-docs/001-AT-ARCH-firestore-schema.md[397-435]
- STATUS.md[1-35]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

"collectionGroup": "articles",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "relevance_score",
"order": "DESCENDING"
},
{
"fieldPath": "published_at",
"order": "DESCENDING"
}
]
},
{
"collectionGroup": "articles",
"queryScope": "COLLECTION",
Comment on lines 1 to 5
Copy link

@qodo-code-review qodo-code-review bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

3. Ci fails: missing relevance index 🐞 Bug ⛯ Reliability

The PR removes the articles(relevance_score DESC, published_at DESC) composite index, but the repo
still has a test that asserts this index must exist. This will fail CI even though the dashboard
query no longer uses relevance_score.
Agent Prompt 
## Issue description
The PR removed the Firestore composite index `articles(relevance_score DESC, published_at DESC)`, but the repo still has an index-validation test that asserts this index must exist. This mismatch will fail CI.

## Issue Context
Dashboard queries now sort by `published_at` only, so the composite index likely isn’t required anymore (unless another feature still uses it).

## Fix Focus Areas
- tests/firebase/test_firestore_indexes.py[112-137]
- firestore.indexes.json[1-16]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Expand Down Expand Up @@ -41,8 +27,7 @@
"order": "DESCENDING"
}
]
}
,
},
{
"collectionGroup": "ingestion_runs",
"queryScope": "COLLECTION",
Expand Down
10 changes: 4 additions & 6 deletions tests/firebase/test_dashboard_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,21 +201,19 @@ def test_user_alerts_query(
)
raise

def test_articles_by_relevance_query(self, firestore_db, skip_without_gcp_auth):
def test_articles_by_newest_query(self, firestore_db, skip_without_gcp_auth):
"""
Articles sorted by relevance (used in recommendations).
Articles sorted by newest first (primary feed ordering).

Query:
collection('articles')
.orderBy('relevance_score', 'desc')
.orderBy('published_at', 'desc')
.limit(20)
"""
from google.cloud.firestore_v1 import Query

query = (
firestore_db.collection("articles")
.order_by("relevance_score", direction=Query.DESCENDING)
.order_by("published_at", direction=Query.DESCENDING)
.limit(20)
)
Expand All @@ -225,8 +223,8 @@ def test_articles_by_relevance_query(self, firestore_db, skip_without_gcp_auth):
except Exception as e:
if "index" in str(e).lower():
pytest.fail(
f"Articles relevance query missing index: {e}\n"
"Add composite index: articles(relevance_score DESC, published_at DESC)"
f"Articles newest query missing index: {e}\n"
"Single-field orderBy shouldn't need composite index"
)
elif "permission" in str(e).lower():
pytest.fail(f"Articles query permission denied: {e}")
Expand Down