Jm/translate startlight docs2 #160
Open
+133
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hreflang link tags to improve SEO for English and Spanish page versions.
JonathanMatthey
changed the base branch from
main
to
sj/translation-infrastructure
Anca2022
reviewed
Nov 27, 2025
Contributor
Anca2022
left a comment
Anca2022
left a comment
There was a problem hiding this comment.
The font for the header should be Titillium Web instead of Tittilium to avoid these characters í, ó, ú etc looking weird
| {Object.entries(alternateUrls).map(([locale, url]) => ( | ||
| <link rel="alternate" hreflang={locale} href={url} /> | ||
| ))} | ||
| <link rel="alternate" hreflang="x-default" href={defaultUrl} /> |
Contributor
There was a problem hiding this comment.
I got to go, so I/m not digging too deep into this, but it is not working as expected when on spanish pages:
Contributor
|
Overall this PR is 🔥🔥🔥 |
Co-authored-by: Anca Matei <[email protected]>
Co-authored-by: Anca Matei <[email protected]>
Co-authored-by: Anca Matei <[email protected]>
Co-authored-by: Anca Matei <[email protected]>
Co-authored-by: Anca Matei <[email protected]>
Co-authored-by: Anca Matei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
LINEAR:
DEVPORT-9: Developer Portal Translation Infrastructure