Check that lut files exist before using the timestamp reported by %RoutineMgr.TS #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymond-rebbeck
force-pushed
the
lut-routinemgr-ts
branch
from
5a701e5 to
5c97311
Compare
…r the purpose of importing The timestamp returned by %RoutineMgr.TS() is always the current time for a lut file that does not exist or has yet to be imported, resulting in such lut files as never being considered as outdated when performing an import. Check that lut files exist before using the returned timestamp, allowing them to be imported.
raymond-rebbeck
force-pushed
the
lut-routinemgr-ts
branch
from
5c97311 to
dd3b244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791
%RoutineMgr.TS()always returns the current time for a lut file that does not already exist preventing import as they do not get considered as outdated.Check that lut files exist using
%RoutineMgr.Exists()before returning the timestamp inSourceControl.Git.Utils.RoutineTSH()This unexpected behaviour with the timestamp only seems to affect lut files, though I have not exhaustively checked every possible supported file type. This seems as though it could be some sort of upstream bug, though is able to be easily worked around in this instance.