Fix OAuth2 token expiration timezone handling #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves timezone handling for OAuth2 access and refresh token expiration dates by:
- Add optional timezone parameter to getAccessTokenExpiresAt() and getRefreshTokenExpiresAt() methods
- Update getDateFromSeconds() to accept timezone parameter and use DateTime with proper timezone conversion
- Default to UTC timezone to maintain backward compatibility
- Include timezone identifier in returned date strings for clarity
This resolves confusion where expiration dates were displayed in server's local timezone without indication, causing users to see incorrect expiration times. Now users can specify their preferred timezone or rely on clear UTC display.
Example usage:
- getAccessTokenExpiresAt() returns "2025/08/28 15:12:34 UTC"
- getAccessTokenExpiresAt('Asia/Jakarta') returns "2025/08/28 22:12:34 Asia/Jakarta"
Fixes issue where token expiration appeared to be set incorrectly due to timezone conversion problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves timezone handling for OAuth2 access and refresh token expiration dates by:
This resolves confusion where expiration dates were displayed in server's local timezone without indication, causing users to see incorrect expiration times. Now users can specify their preferred timezone or rely on clear UTC display.
Example usage:
Fixes issue where token expiration appeared to be set incorrectly due to timezone conversion problems.