Skip to content

add refresh buttons for new position and position details#641

Draft
p6te wants to merge 17 commits intodevfrom
add-refresh-button-to-add-liquidity-and-position-details
Draft

add refresh buttons for new position and position details#641
p6te wants to merge 17 commits intodevfrom
add-refresh-button-to-add-liquidity-and-position-details

Conversation

@p6te
Copy link
Copy Markdown
Contributor

@p6te p6te commented Mar 26, 2024

add refresh buttons for new position and position details.

image

image

PR will be finished after merge #662

Copy link
Copy Markdown
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh on position details is not working correctly. Every time I click the refresh button on the "position details," my unclaimed fees change to 0, even though there are accumulated fees in this position

@wojciech-cichocki
Copy link
Copy Markdown
Member

Refresh on position details is not working correctly. Every time I click the refresh button on the "position details," my unclaimed fees change to 0, even though there are accumulated fees in this position

Additionally, the liquidity chart should also be redrawn

Copy link
Copy Markdown
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested that refreshing closed position and redirecting to the position list works correctly

Copy link
Copy Markdown
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indexes of selected ticks should not be reset upon refreshing on the "add liquidity" view

Copy link
Copy Markdown
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include a global price update in the refresh button and align this PR with the master

@p6te p6te marked this pull request as draft April 12, 2024 16:56
@github-actions
Copy link
Copy Markdown

This pull request has been deployed to Vercel.

Latest commit: 5b55792
✅ Preview: https://webapp-cr288xf19-invariantlabs.vercel.app
🔍 Inspect: https://vercel.com/invariantlabs/webapp/HfKvJvpCZKxuPQHSWZ13viWBgEjc

View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants