Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use / in relative path for Windows #788

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented Nov 8, 2024

Description

As we all know, Windows uses \ as a path separator, so it is reasonable to generate configs that use the same separator for Windows. But for Run Configurations and Pubspec Dependencies, / works on all platforms. Using / will significantly reduce the pain when those configurations are checked out to their code version control.

This is first implemented by 86a87a6.

Diff on Windows

Before:

<component name="ProjectRunConfigurationManager">
  <configuration default="false" name="Flutter Run -&gt; 'app'" type="FlutterRunConfigurationType" factoryName="Flutter">
    <option name="filePath" value="$PROJECT_DIR$/app\lib\main.dart" />
    <method v="2" />
  </configuration>
</component>
dependency_overrides:
  package_a:
    path: ..\\package_a

After:

<component name="ProjectRunConfigurationManager">
  <configuration default="false" name="Flutter Run -&gt; 'app'" type="FlutterRunConfigurationType" factoryName="Flutter">
    <option name="filePath" value="$PROJECT_DIR$/app/lib/main.dart" />
    <method v="2" />
  </configuration>
</component>
dependency_overrides:
  package_a:
    path: ../package_a

Type of Change

  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)

Copy link

docs-page bot commented Nov 8, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~788

Documentation is deployed and generated using docs.page.

@AlexV525 AlexV525 changed the title 🐛 Use / in relative path for Windows fix: Use / in relative path for Windows Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant