fix!: improve error handling for finalizeMultiFactorEnrollment

invertase · Jan 14, 2024 · 95dd587 · 95dd587
1 parent 57ed042
commit 95dd587
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/.../auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java b/.../auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java
@@ -1241,12 +1241,14 @@ public void finalizeMultiFactorEnrollment(
         .enroll(assertion, displayName)
         .addOnCompleteListener(
             task -> {
-              if (!task.isSuccessful()) {
-                rejectPromiseWithExceptionMap(promise, task.getException());
+              if (task.isSuccessful()) {
+                Log.d(TAG, "finalizeMultiFactorEnrollment:onComplete:success");
+                promise.resolve(null);
+              } else {
+                Exception exception = task.getException();
+                Log.e(TAG, "finalizeMultiFactorEnrollment:onComplete:failure", exception);
+                promiseRejectAuthException(promise, exception);
               }
-
-              // Need to reload user to make it all visible?
-              promise.resolve("yes");
             });
   }