test(ci): use ubuntu-current for emulator / macos-14 for simulator #7608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikehardy
force-pushed
the
@mikehardy/new-action-runner-perf
branch
from
daf7a1f to
d98717c
Compare
mikehardy
force-pushed
the
@mikehardy/new-action-runner-perf
branch
from
c09ecab to
5c64e0f
Compare
the new actions runners for ubuntu have nested virt enabled, they are way faster than the non-apple-silicon runners, and the new apple silicon runners do not have nested virt these ubuntu runners are also not limited by the reduced concurrency the macos runners have - AVDs need a lot of disk, put them on /mnt/avd - AVD cache uses more time than it saves in new runner images - with unlimited concurrency, run a min-possible + max-possible API skew
the new apple silicon runner should be substantially faster, additionally we should switch to an iPhone definition that is included by default in Xcode 15 since we're moving all the way from macos-12 to macos-14 runner and the Xcode (with its simulator definitions) is jumping versions
mikehardy
force-pushed
the
@mikehardy/new-action-runner-perf
branch
from
ec8b694 to
ac1a963
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7608 +/- ##
============================================
- Coverage 53.29% 53.22% -0.07%
Complexity 742 742
============================================
Files 251 251
Lines 12426 12426
Branches 1938 1938
============================================
- Hits 6621 6612 -9
- Misses 5455 5466 +11
+ Partials 350 348 -2 |
should get rid of all the deprecated node warnings
if used in a matrix with more than one expansion entry, the log name needs the expansion variables or the upload collides and fails
mikehardy
force-pushed
the
@mikehardy/new-action-runner-perf
branch
from
e4f2541 to
7b1af8f
Compare
…imulators This used to work fine with iOS16 through 17.1, but now with 17.2 registerForRemoteNotifications hangs Since we can't call that, we can't touch any of the getToken type methods, so add 17.2 to list of unsupported emulators, and skip token-related items for it
Fixes #7272 with thanks to @appa-gomi !
mikehardy
force-pushed
the
@mikehardy/new-action-runner-perf
branch
from
7b1af8f to
26dd14a
Compare
mikehardy
commented
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new public repo actions runner changes where apple silicon with macos-14 is available and ubuntu runners with nested virt are available represent an opportunity for a very large performance gain in our e2e test loads
The e2e test performance for Android is same time on API34 but it does work so we can test max-API, and now without concurrency limits we can add in a minimum API as well (23 is tested and working) as a matrix
The e2e test for iOS is currently hanging on remote message de-registration and troubleshooting is in progress
Release Summary
conventional commits, it's test related so no release will trigger
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
It is made of tests!
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter