Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app, ios): note pod install required for ios_config changes #7631

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

This wastes developer time and deserves a big note

Related issues

Idea from invertase/react-native-google-mobile-ads#550

Release Summary

docs only, no release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Documentation in form of shell script comments only, no tests needed though obviously iOS e2e should pass to confirm that


Think react-native-firebase is great? Please consider supporting the project with any of the below:

This wastes developer time and deserves a big note
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview Feb 19, 2024 3:56pm

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #7631 (fc0c795) into main (2ff569d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7631   +/-   ##
=========================================
  Coverage     53.22%   53.22%           
  Complexity      742      742           
=========================================
  Files           251      251           
  Lines         12426    12426           
  Branches       1938     1938           
=========================================
  Hits           6612     6612           
  Misses         5466     5466           
  Partials        348      348           

@mikehardy mikehardy merged commit 9e9255a into main Feb 19, 2024
19 checks passed
@mikehardy mikehardy deleted the @mikehardy/ios-config-note branch February 19, 2024 21:58
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant