feat(analytics, ios): add Podfile toggle to optionally link AdSupport #7637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://firebase.google.com/support/guides/analytics-adsupport
Ads the ability to define '$RNFirebaseAnalyticsEnableAdSupport' in order to handle the linking for you to get the optional features.
For example, in. Podfile near the top, you may do this and it should Just Work:
Note that this will only work with the AdId support enabled, it is mutually exclusive with
RNFirebaseAnalyticsWithoutAdIdSupport
Podfile toggle, as it makes no sense to link theAdSupport
framework while linking the Firebase Analytics pod that does not contain AdId supportRelated issues
Fixes
Release Summary
conventional commits
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
This is an optional toggle in a Podfile that did not exist before so it cannot by definition break things.
Needs user testing over time to see if the use of this toggle is sufficient to include the optional extra analytics features, but it does align with the documentation from upstream firebase analytics and apple though
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter