Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics, ios): add Podfile toggle to optionally link AdSupport #7637

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Feb 21, 2024

Description

See https://firebase.google.com/support/guides/analytics-adsupport

Ads the ability to define '$RNFirebaseAnalyticsEnableAdSupport' in order to handle the linking for you to get the optional features.

For example, in. Podfile near the top, you may do this and it should Just Work:

$RNFirebaseAnalyticsEnableAdSupport = true

Note that this will only work with the AdId support enabled, it is mutually exclusive with RNFirebaseAnalyticsWithoutAdIdSupport Podfile toggle, as it makes no sense to link the AdSupport framework while linking the Firebase Analytics pod that does not contain AdId support

Related issues

Fixes

Release Summary

conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

This is an optional toggle in a Podfile that did not exist before so it cannot by definition break things.

Needs user testing over time to see if the use of this toggle is sufficient to include the optional extra analytics features, but it does align with the documentation from upstream firebase analytics and apple though


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2024 11:49pm

@mikehardy
Copy link
Collaborator Author

mikehardy commented Feb 21, 2024

Waiting for some testing feedback on related #7027
If feedback is good, needs documentation updates on ios manual install steps and main ios install to expose the feature and how to use it

@mikehardy
Copy link
Collaborator Author

No feedback yet but I can't see how this could break anything. At worst can polish a little after.
Just pending the documentation updates now

@mikehardy mikehardy added Workflow: Needs Review Pending feedback or review from a maintainer. and removed Workflow: Waiting for User Response Blocked waiting for user response. labels Feb 25, 2024
@mikehardy mikehardy force-pushed the @mikehardy/optionally-link-adsupport-framework branch from 4eb6eb9 to d761870 Compare February 25, 2024 23:44
@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels Feb 25, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #7637 (d761870) into main (44a2efe) will increase coverage by 10.08%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7637       +/-   ##
===========================================
+ Coverage   23.16%   33.24%   +10.08%     
===========================================
  Files         133      251      +118     
  Lines        5528    12460     +6932     
  Branches     1250     1944      +694     
===========================================
+ Hits         1280     4141     +2861     
- Misses       3560     8230     +4670     
+ Partials      688       89      -599     

@mikehardy mikehardy merged commit e4db9bb into main Feb 26, 2024
18 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/optionally-link-adsupport-framework branch February 26, 2024 02:27
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant