Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, sdks)!: SDK ios 10.21.0 / android / 32.7.2 #7638

Merged
merged 6 commits into from
Feb 25, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

Update dependencies, with the most important change being a transitive requirement to enforce a new minimum requirement for cocoapods version of 1.12.0 - coming in from firebase-ios-sdk in order to support Apple's new Privacy Manifests

This is a tiny, easily met breaking change but is still potentially breaking

Release Summary

conventional commits, and the ! and BREAKING CHANGES notes in the commit message are patterned off previous ones that correctly generated a great CHANGELOG entry with the information developers need on what the break is and how to handle it

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

CI needs to pass as well as local testing - it all passes for me


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 6:18pm

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Feb 21, 2024
- new google-services gradle plugin 4.4.1
- new app-distribution gradle plugin 4.1.0
- new app-distribution api 16.0.0-beta12

BREAKING CHANGE: firebase-ios-sdk 10.21.0 requires cocoapods 1.12+
in order to support the new Apple-mandated privacy manifests. Please
ensure you are using verson 1.12 or greater of cocoapods
from previous PR adding warning about needing to pod install
the new runners have more and more tools and slightly less
disk space, leading to out of space errors
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #7638 (78fd569) into main (6952656) will decrease coverage by 34.82%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7638       +/-   ##
===========================================
- Coverage   68.07%   33.24%   -34.82%     
===========================================
  Files         149      251      +102     
  Lines        5943    12460     +6517     
  Branches     1250     1944      +694     
===========================================
+ Hits         4045     4141       +96     
- Misses       1801     8230     +6429     
+ Partials       97       89        -8     

@Summys
Copy link
Contributor

Summys commented Feb 23, 2024

I've seen some issues where the PrivacyInfo file is not picked by xcode's Generate Privacy Report tool if the framework is static. Have you encountered it?

@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 23, 2024
@mikehardy
Copy link
Collaborator Author

@Summys 🤔 no I have not encountered this but the main reason why is that although I'm working as quickly as possible to expose the new firebase-ios-sdk release that supports the privacy manifests, that has left me no time to actually try it at the app layer yet. So I simply haven't tried 😬

Is this observation (that Xcode is not picking them up, perhaps because they are static) based on experience with other libraries? Or have you already incorporated the patchset from here and tried it and you are not seeing the firebase-ios-sdk manifests?

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Feb 23, 2024
@Summys
Copy link
Contributor

Summys commented Feb 23, 2024

@mikehardy didn't test the patchset, but from other static frameworks. Maybe that's intended and the PrivacyInfo of these static framework should be included in the app's Privacy.

@mikehardy
Copy link
Collaborator Author

@Summys 🤔 I wish I had more experience here, I'm sorry that I don't. I'm going to send up a bat signal that I try to use rarely to preserve it's power 😆 @paulb777 - are you aware of any limitations with App Privacy Manifest inclusion when libraries are linked statically? Is there an documentation on how exactly to do the app privacy manifest thing for firebase-ios-sdk when included user apps?

(for reference: users here link via use_frameworks! :linkage => :static in app Podfiles)

@paulb777
Copy link
Contributor

@mikehardy We're still in the implementation phase, but early testing by @ncooke shows that the manifest shows up in the privacy report:

Static Linking
Configurable via when use_frameworks! :linkage => :static is specified in Podfile
As specified in the podspec, the generated bundle is named FirebaseSharedSwiftResources and referenced in the encompassing app’s privacy report below.

Screenshot 2024-02-23 at 6 50 38 AM

Because CocoaPods is statically linking the xcframework it builds from the source-based podspec, only the generated resource bundle is embedded within the app’s bundle.

@mikehardy
Copy link
Collaborator Author

Nothing more to do on this one, I'm always a little slower on breaking changes (even though this one is really trivial to handle - just cocoapods from last year as a new minimum) but I can't see anything else to do, so here we go

@mikehardy mikehardy merged commit 44a2efe into main Feb 25, 2024
17 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch February 25, 2024 15:46
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants