-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, sdks)!: SDK ios 10.21.0 / android / 32.7.2 #7638
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- new google-services gradle plugin 4.4.1 - new app-distribution gradle plugin 4.1.0 - new app-distribution api 16.0.0-beta12 BREAKING CHANGE: firebase-ios-sdk 10.21.0 requires cocoapods 1.12+ in order to support the new Apple-mandated privacy manifests. Please ensure you are using verson 1.12 or greater of cocoapods
from previous PR adding warning about needing to pod install
8db0371
to
17afe31
Compare
the new runners have more and more tools and slightly less disk space, leading to out of space errors
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7638 +/- ##
===========================================
- Coverage 68.07% 33.24% -34.82%
===========================================
Files 149 251 +102
Lines 5943 12460 +6517
Branches 1250 1944 +694
===========================================
+ Hits 4045 4141 +96
- Misses 1801 8230 +6429
+ Partials 97 89 -8 |
I've seen some issues where the PrivacyInfo file is not picked by xcode's Generate Privacy Report tool if the framework is static. Have you encountered it? |
@Summys 🤔 no I have not encountered this but the main reason why is that although I'm working as quickly as possible to expose the new firebase-ios-sdk release that supports the privacy manifests, that has left me no time to actually try it at the app layer yet. So I simply haven't tried 😬 Is this observation (that Xcode is not picking them up, perhaps because they are static) based on experience with other libraries? Or have you already incorporated the patchset from here and tried it and you are not seeing the firebase-ios-sdk manifests? |
@mikehardy didn't test the patchset, but from other static frameworks. Maybe that's intended and the PrivacyInfo of these static framework should be included in the app's Privacy. |
@Summys 🤔 I wish I had more experience here, I'm sorry that I don't. I'm going to send up a bat signal that I try to use rarely to preserve it's power 😆 @paulb777 - are you aware of any limitations with App Privacy Manifest inclusion when libraries are linked statically? Is there an documentation on how exactly to do the app privacy manifest thing for firebase-ios-sdk when included user apps? (for reference: users here link via |
@mikehardy We're still in the implementation phase, but early testing by @ncooke shows that the manifest shows up in the privacy report: Static Linking Because CocoaPods is statically linking the xcframework it builds from the source-based podspec, only the generated resource bundle is embedded within the app’s bundle. |
Nothing more to do on this one, I'm always a little slower on breaking changes (even though this one is really trivial to handle - just cocoapods from last year as a new minimum) but I can't see anything else to do, so here we go |
Description
Update dependencies, with the most important change being a transitive requirement to enforce a new minimum requirement for cocoapods version of 1.12.0 - coming in from firebase-ios-sdk in order to support Apple's new Privacy Manifests
This is a tiny, easily met breaking change but is still potentially breaking
Release Summary
conventional commits, and the
!
andBREAKING CHANGES
notes in the commit message are patterned off previous ones that correctly generated a greatCHANGELOG
entry with the information developers need on what the break is and how to handle itChecklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
CI needs to pass as well as local testing - it all passes for me
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter