-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(app-check): deprecation warning for v8 API ahead of future major release #8198
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v8-deprecations #8198 +/- ##
==================================================
Coverage ? 71.37%
==================================================
Files ? 155
Lines ? 6453
Branches ? 1475
==================================================
Hits ? 4605
Misses ? 1727
Partials ? 121 |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
49552e6
to
b21ad22
Compare
4cde55c
to
d3c8644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI agrees
I think this one and the analytics ones are where all the infra work you did in the first couple start to make it go quickly 🤞
Hi @mikehardy, hope you're doing well. After this deprecation notice there's a huge pollution in the logs :/ look how small is the scrollbar on the right 😅 don't tell me to move to v9 lol! |
@efstathiosntonas I will go farther: I will insist you move to v9. There is literally no alternative, the future is no longer the future, the future is right now. The transition is actually easy though - I feared it personally in my projects and in the end was painless. |
@mikehardy I knew it haha! do you have any mini guide on how to transition? will I need |
@efstathiosntonas you only need to do initializeApp if you are using the "other" platform support (react-native-macos or web) which you are likely not doing - or if you are initializing secondary / non- All the other stuff you need to change though - it's basically just each time you used to do this:
Now you do
That's it. |
great, thanks Mike, will try it now. |
best part is it is incremental at least - you can nail your hottest offenders right now to get your logs mostly clean, then do full sweep later with time available |
@efstathiosntonas - I know why. If you want to open a new issue, I'll get that fixed 👍 |
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter