Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app-check): deprecation warning for v8 API ahead of future major release #8198

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 20, 2024

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 4:58pm

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v8-deprecations@10e618f). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             v8-deprecations    #8198   +/-   ##
==================================================
  Coverage                   ?   71.37%           
==================================================
  Files                      ?      155           
  Lines                      ?     6453           
  Branches                   ?     1475           
==================================================
  Hits                       ?     4605           
  Misses                     ?     1727           
  Partials                   ?      121           

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jan 17, 2025
@github-actions github-actions bot closed this Feb 1, 2025
@mikehardy mikehardy reopened this Feb 2, 2025
@mikehardy mikehardy removed the Stale label Feb 2, 2025
@mikehardy mikehardy force-pushed the v8-deprecations branch 2 times, most recently from 49552e6 to b21ad22 Compare February 3, 2025 13:21
Base automatically changed from v8-deprecations to main February 3, 2025 13:46
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI agrees
I think this one and the analytics ones are where all the infra work you did in the first couple start to make it go quickly 🤞

@mikehardy mikehardy merged commit 8b01d5e into main Feb 3, 2025
19 checks passed
@mikehardy mikehardy deleted the app-check-deprecations branch February 3, 2025 21:02
@efstathiosntonas
Copy link
Contributor

efstathiosntonas commented Feb 6, 2025

Hi @mikehardy, hope you're doing well.

After this deprecation notice there's a huge pollution in the logs :/

look how small is the scrollbar on the right 😅

don't tell me to move to v9 lol!

Screenshot 2025-02-06 at 09 32 21

@mikehardy
Copy link
Collaborator

@efstathiosntonas I will go farther: I will insist you move to v9. There is literally no alternative, the future is no longer the future, the future is right now. The transition is actually easy though - I feared it personally in my projects and in the end was painless.

@efstathiosntonas
Copy link
Contributor

@mikehardy I knew it haha!

do you have any mini guide on how to transition?

will I need initializeApp? Tried earlier to do so, thought it would pick from google services json or plist but nope 😓

@mikehardy
Copy link
Collaborator

mikehardy commented Feb 6, 2025

@efstathiosntonas you only need to do initializeApp if you are using the "other" platform support (react-native-macos or web) which you are likely not doing - or if you are initializing secondary / non-[DEFAULT] apps, at which point you were already doing it and wouldn't have had a problem. We still handle initialization.

All the other stuff you need to change though - it's basically just each time you used to do this:

  • get handle to main object for service (e.g. const auth = firebase.auth())
  • call method on that main object (e.g. auth.doThing(param1, param2)

Now you do

  • get handle to main object for service (e.g. const auth = getAuth(getApp()))
  • call method using that main object (e.g. doThing(auth, param1, param2))

That's it.

@efstathiosntonas
Copy link
Contributor

great, thanks Mike, will try it now.

@mikehardy
Copy link
Collaborator

best part is it is incremental at least - you can nail your hottest offenders right now to get your logs mostly clean, then do full sweep later with time available

@efstathiosntonas
Copy link
Contributor

any idea why?

Screenshot 2025-02-06 at 14 40 50

@russellwheatley
Copy link
Member Author

@efstathiosntonas - I know why. If you want to open a new issue, I'll get that fixed 👍

@efstathiosntonas
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants