Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging): added Expo config section #8245

Closed
wants to merge 1 commit into from

Conversation

mwmcode
Copy link

@mwmcode mwmcode commented Jan 23, 2025

Description

Expo config guide

Related issues

#8167

Release Summary

I recently migrated a bare RN app to Expo v52 and came across the issue mentioned above so I thought I give it a try.

Let me know if it needs to be updated slash feel free to update it.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • [] Android
    • [] iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:32am

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025

CLA assistant check
All committers have signed the CLA.

@mwmcode mwmcode changed the title Create expo-setup docs(messaging): added Expo config section Jan 23, 2025
@mwmcode
Copy link
Author

mwmcode commented Jan 23, 2025

Just came across #8212 (related)

@mikehardy
Copy link
Collaborator

Hey - 2 things - first - sorry for letting the original PR sit so long that it tempted anyone (and specifically you) into spending time on duplicate work by not closing the issue, and second - thanks very much for taking a crack at contributing either way. I do sincerely appreciate it

I went ahead and merged the other one since it was super-focused on the exact issue - this one mixed in a fair bit of core-module/app config (with the suggested changes to add the json/plist) and also added in the fetch background mode which is not messaging-specific and may not be needed for everyone, so it was a bit less focused.

That said, if our app install section for the core module doesn't show people how to add the plist or json files (does it? I'm unsure, sorry) then taking that chunk from this PR and finding a good place to pop it directly into the install page for that module could help people?

@mikehardy mikehardy closed this Jan 23, 2025
@mwmcode
Copy link
Author

mwmcode commented Jan 23, 2025

Hi @mikehardy no worries. Somehow I didn't see the first PR until after I opened this.

Regarding the fetch background mode, I just followed the iOS setup page which suggests adding it too.

As for the json files, I mentioned them to show where they go in Expo apps and how they're referenced in app.json.

👆 just clarifying the configs I suggested in the PR. I think a better approach is to have an Expo section in each page rather having them in different pages.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants