Skip to content

docs: Add instructions for iOS AppDelegate.swift on react-native 0.77 #8265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

bigriot
Copy link
Contributor

@bigriot bigriot commented Feb 5, 2025

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 6:18pm

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@bigriot bigriot changed the title Added instructions for iOS AppDelegate.swift on react-native 0.77 docs /Added instructions for iOS AppDelegate.swift on react-native 0.77 Feb 5, 2025
@bigriot bigriot changed the title docs /Added instructions for iOS AppDelegate.swift on react-native 0.77 docs: Added instructions for iOS AppDelegate.swift on react-native 0.77 Feb 5, 2025
@bigriot bigriot changed the title docs: Added instructions for iOS AppDelegate.swift on react-native 0.77 docs: Add instructions for iOS AppDelegate.swift on react-native 0.77 Feb 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Mar 5, 2025
@github-actions github-actions bot closed this Mar 20, 2025
@mikehardy mikehardy reopened this Mar 20, 2025
@github-actions github-actions bot removed the Stale label Mar 20, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry for the delay here, the doc changes are of course correct

I ran yarn lint:markdown --write to fixup the trivial spacing issue lint noticed

I rebased to current main to fix the yarn lerna:prepare issue in CI for the unrelated vertexai package

Everything should go green after this and it'll be good to merge

Thanks again!

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 21, 2025
@mikehardy mikehardy merged commit 9c1a9a8 into invertase:main Mar 21, 2025
9 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants