Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote-config): support for custom signals #8274

Merged
merged 10 commits into from
Feb 9, 2025

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 6, 2025

Description

  • Support is for modular only.
  • There are discrepancies between native SDKs. iOS will throw if you pass in wrong type (a dictionary is passed in as CustomSignals), I can't see any incorrect type handling on JS (although you ought to get TS warning if incorrect type I think), and android enforces a CustomSignal type which only allows long, double, string and null values. Therefore, we throw exception early if not number, string or null to keep some form of consistency.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:05pm

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - really minor nitpicky type comments so attempted to frame them all as committable suggestions to not bog down. All of them are take it or leave it, I'm +1 on merge regardless as they're just opinions not correctness issues

@mikehardy mikehardy added plugin: remote_config Firebase Remote Config Workflow: Needs Review Pending feedback or review from a maintainer. type: enhancement Implements a new Feature Workflow: Pending Merge Waiting on CI or similar labels Feb 6, 2025
@mikehardy
Copy link
Collaborator

of course my text-box code suggestions fail lint 😆

@mikehardy mikehardy removed Workflow: Needs Review Pending feedback or review from a maintainer. Workflow: Pending Merge Waiting on CI or similar labels Feb 9, 2025
@mikehardy mikehardy merged commit 94c6a27 into main Feb 9, 2025
17 of 19 checks passed
@mikehardy mikehardy deleted the remote-config-custom-signals branch February 9, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: remote_config Firebase Remote Config type: enhancement Implements a new Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants