-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote-config): support for custom signals #8274
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - really minor nitpicky type comments so attempted to frame them all as committable suggestions to not bog down. All of them are take it or leave it, I'm +1 on merge regardless as they're just opinions not correctness issues
...droid/src/reactnative/java/io/invertase/firebase/config/ReactNativeFirebaseConfigModule.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Hardy <[email protected]>
of course my text-box code suggestions fail lint 😆 |
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter