-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deprecation guide for moving to firebase-js-sdk modular API #8279
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/index.md
Outdated
@@ -4,6 +4,9 @@ description: Welcome to React Native Firebase! To get started, you must first se | |||
next: /typescript | |||
--- | |||
|
|||
> React Native Firebase has begun to deprecate the namespaced API (i.e firebase-js-sdk `< v9` chaining API). React Native Firebase will be moving to the modular API (i.e. firebase-js-sdk `>= v9`) in the next major release. See [migration guide]() for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks beautiful except the guide isn't hooked up to the URL here and the prev/next links need rearrange, you probably know that
only commenting to say this all looks like a +1 from me otherwise, even though it's draft at moment
Feedback from a user:
The deprecation message should connect any mention of v8/v9 explicitly to firebase-js-sdk, maybe should have a link to the migration guide as well ? |
@mikehardy - I've made some updates.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really close on this one I feel - what do you think of the proposed changes @russellwheatley
|
||
### Migration Help | ||
|
||
You will find code snippets for "Web namespaced API" and "Web modular API" throughout the official Firebase documentation. Update your code to use "Web modular API". Here are some links to help you get started: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fantastic
Forgive me, and obviously we can do follow-ons, but I need to merge this so I can point to it for user support now |
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter