feat(expo): enhances notification config retrieval #8663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Ping @mikehardy - @MichaelVerdon to get your opinion on this |
|
just closing and reopening to make sure CI runs, it appears to be hung for some reason |
Improves notification configuration by first checking `expo-notifications` plugin for icon and color. Falls back to deprecated `config.notification` settings. Warns about missing notification icon for Android.
huextrat
force-pushed
the
feat/expo-notifications
branch
from
ac96a96 to
baf4c89
Compare
I did a rebase on latest main + fix lint |
|
duplicate test b263759 to make sure both configuration are working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expo 54 will deprecate the use of
notificationin expo config in favor ofexpo-notificationsexpo plugin : https://docs.expo.dev/versions/v54.0.0/config/app/#notificationImproves notification configuration by first checking
expo-notificationsplugin for icon and color.Falls back to deprecated
config.notificationsettings. Warns about missing notification icon for Android.Related issues
fixes: #8664
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter