-
Notifications
You must be signed in to change notification settings - Fork 74
ci: add turbo and release workflow #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~184 Documentation is deployed and generated using docs.page. |
4a8aebf
to
d28c017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Turborepo-based task orchestration and a Changesets-driven release workflow, updating CI/CD pipelines for formatting, testing with Firebase emulators, and automated releases.
- Added
turbo.json
with build, test, and dev tasks managed by Turborepo - Integrated Changesets configuration and scripts for versioning and publishing
- Updated GitHub Actions workflows: separate quality (format) and test jobs, plus a dispatchable release workflow
Reviewed Changes
Copilot reviewed 87 out of 99 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
turbo.json | Defines global dependencies and tasks (build , test , dev ) |
package.json (root) | Added Turborepo, Changesets, and release scripts |
.github/workflows/tests.yaml | Split jobs into quality (format) and test (emulator-based) |
.github/workflows/release.yml | New workflow for manual release dispatch with Changesets checks |
.changeset/config.json | Configured Changesets schema and access rules |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/tests.yaml:31
- [nitpick] The
quality
job currently only runs a format check. Consider adding lint and type‐check steps (e.g. Biome lint, TypeScripttsc --noEmit
) to enforce code quality before tests.
- name: Run format check
packages/react/src/firestore/useWaitForPendingWritesQuery.test.tsx:2
- The test still references
waitFor
but its import was removed. Re-addwaitFor
to the import from@testing-library/react
or remove usages.
import { renderHook } from "@testing-library/react";
This PR: