Skip to content

Conversation

@HassanBahati
Copy link
Member

When you ran pnpm install at the root directory, the package-lock.json updates to include ^12.0.0 added via #227

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: 4191ab8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@docs-page
Copy link

docs-page bot commented Oct 29, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~228

Documentation is deployed and generated using docs.page.

@gemini-code-assist
Copy link

Summary of Changes

Hello @HassanBahati, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project's dependency lock file to officially incorporate support for Firebase version 12. By modifying the pnpm-lock.yaml, it ensures that the dataconnect-sdk/js/default-connector can correctly resolve and function with the latest Firebase versions, thereby preventing potential dependency conflicts and enabling developers to seamlessly utilize Firebase v12.

Highlights

  • Dependency Update: The pnpm-lock.yaml file has been updated to reflect support for Firebase version 12.
  • Peer Dependency Range Expansion: The firebase peer dependency range for the dataconnect-sdk/js/default-connector has been expanded to include ^12.0.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-lock.yaml file to reflect the added support for Firebase v12 in the @dataconnect/default-connector package's peer dependencies. This change is a standard lock file update that aligns with the modifications in the package's package.json. The update is correct and necessary to ensure dependency consistency. The changes look good.

Copy link
Collaborator

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cabljac cabljac merged commit 3d757db into main Oct 30, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Open Source P0 Oct 30, 2025
@cabljac cabljac deleted the update-lock-file-with-firebase-v12-support branch October 30, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants