(fix): Fix controlnet import for latest diffusers version bump #8560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipsterusername
requested review from
lstein,
blessedcoolant,
psychedelicious and
maryhipp
as code owners
github-actions
bot
added
python
hipsterusername
force-pushed
the
controlnet-fix-diffusers
branch
from
c78b9e8 to
430bb3b
Compare
hipsterusername
force-pushed
the
controlnet-fix-diffusers
branch
from
430bb3b to
21a05f4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| try: | ||
| diffusers.models.controlnet.ControlNetModel = ControlNetModel | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
Bug: Incompatible Import Path Breaks Module Compatibility
The module's import statement unconditionally uses the new diffusers.models.controlnets.controlnet path. This causes an ImportError on older diffusers versions, preventing the module from loading and making the patching logic's compatibility fallback unreachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates a deprecated import on latest diffusers, once we upgrade to it.
Related Issues / Discussions
Qwen image.
QA Instructions
Test that controlnets work.
Merge Plan
Merge alongside diffusers update, or include this fix in that PR.
Checklist
What's Newcopy (if doing a release after this PR)