Add support for external node builders#292
Open
TheParadoxBox wants to merge 4 commits into
Open
Conversation
Author
|
Something I did makes it segfault when you create a new map. Converting to draft until this is solved. |
Author
|
Turns out I missed a guard on the new RunExternalBuilder function and it was trying to build nodes for read-only WADs. Either way, it's good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. Includes basic setup GUI with the other node builder settings:
Also prints external node builder output to the log viewer. Tested on Linux with ZokumBSP (actually a wrapper for ZokumBSP since it likes to throw a fit if it doesn't find node builder lumps on Linux), but should work on any desktop with any node builder.