-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(reorder): add new ionReorderStart, ionReorderMove, ionReorderEnd event playgrounds #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a few nit/grammatical comments, but nothing worth blocking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Changes
Using ionReorderStart and ionReorderEnd
andUsing ionReorderMove
@deprecated
events (this was previously not accounted for at all) and updates the styling for deprecated propsExample of the new styles (the deprecated property was added just to show the visual updates, I did not deprecate
disabled
):Previews