Skip to content

docs(reorder): add new ionReorderStart, ionReorderMove, ionReorderEnd event playgrounds #4149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 23, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jun 12, 2025

Changes

Example of the new styles (the deprecated property was added just to show the visual updates, I did not deprecate disabled):

Before After
before after

Previews

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 2:06pm

@brandyscarney brandyscarney marked this pull request as ready for review June 13, 2025 20:56
@brandyscarney brandyscarney requested a review from a team as a code owner June 13, 2025 20:56
@brandyscarney brandyscarney requested review from ShaneK and thetaPC and removed request for a team June 13, 2025 20:56
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few nit/grammatical comments, but nothing worth blocking for.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@brandyscarney brandyscarney merged commit e9cc2a9 into feature-8.7 Jun 23, 2025
4 checks passed
@brandyscarney brandyscarney deleted the FW-6539 branch June 23, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants