Skip to content

docs(radio): point to correct v7 usage for comparewith #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 8, 2025

The v7 version of the Radio API docs was pointing to the v8 playground example for comparewith.

Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 8:35pm

@@ -1,5 +1,5 @@
```ts
import { Component } from '@angular/core';
import { Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately necessary in order for this example to work due to ionic-team/ionic-framework#29870 not being fixed until v8

@brandyscarney brandyscarney marked this pull request as ready for review August 8, 2025 20:33
@brandyscarney brandyscarney requested a review from a team as a code owner August 8, 2025 20:33
@brandyscarney brandyscarney requested a review from ShaneK August 8, 2025 20:33
@brandyscarney brandyscarney merged commit 51ac3c3 into main Aug 11, 2025
4 checks passed
@brandyscarney brandyscarney deleted the docs/radio-v7-usage branch August 11, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants