fix(utils): apply focus styles on iOS when using Tab with a hardware keyboard #30116
+31
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
github-actions
bot
added
package: angular
github-actions
bot
removed
package: angular
brandyscarney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
When using an external keyboard and tabbing on an iPad, the focus state is not visible until the
Shiftkey is pressed. This happens because the iPad does not fire thekeydownevent when pressingTab.What is the new behavior?
The
ion-focusedclass is now applied only when pointer events are not involved, instead of listening for keyboard events.Does this introduce a breaking change?
Other information
Dev build:
8.6.3-dev.11751478001.1cb7436f