Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): update helper text and counter color #30148

Open
wants to merge 16 commits into
base: feature-8.5
Choose a base branch
from
+299 −177
Open

fix(textarea): update helper text and counter color #30148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3c3118e
feat(textarea): add css vars for helper and error text
brandyscarney Jan 22, 2025
be50374
test(textarea): update e2e test for new vars
brandyscarney Jan 22, 2025
30602f7
chore(): add updated snapshots
brandyscarney Jan 22, 2025
bc5a444
chore: build
brandyscarney Jan 22, 2025
baa1981
refactor(textarea): remove css vars
brandyscarney Jan 22, 2025
9a8400b
test(textarea): update e2e test for custom css
brandyscarney Jan 22, 2025
07d5cd3
chore(): add updated snapshots
brandyscarney Jan 22, 2025
02af8cc
test(textarea): update e2e test naming
brandyscarney Jan 22, 2025
7a8c4de
chore(): add updated snapshots
brandyscarney Jan 22, 2025
e7536f3
style: lint
brandyscarney Jan 22, 2025
938a83e
fix(textarea): update counter color
brandyscarney Jan 22, 2025
a7f5c01
chore(): add updated snapshots
brandyscarney Jan 22, 2025
71bede9
style: remove escape
brandyscarney Jan 22, 2025
768a8bc
test(textarea): hide toggle fill button on ios
brandyscarney Jan 23, 2025
c7f490c
Merge branch 'feature-8.5' into ROU-11559
brandyscarney Jan 27, 2025
e45da2b
Merge branch 'feature-8.5' into ROU-11559
brandyscarney Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...t/a11y/textarea.e2e.ts-snapshots/textarea-scale-ios-ltr-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../a11y/textarea.e2e.ts-snapshots/textarea-scale-ios-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t/a11y/textarea.e2e.ts-snapshots/textarea-scale-ios-ltr-Mobile-Safari-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...st/a11y/textarea.e2e.ts-snapshots/textarea-scale-md-ltr-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t/a11y/textarea.e2e.ts-snapshots/textarea-scale-md-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...st/a11y/textarea.e2e.ts-snapshots/textarea-scale-md-ltr-Mobile-Safari-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
112 changes: 79 additions & 33 deletions core/src/components/textarea/test/bottom-content/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<style>
.grid {
display: grid;
grid-template-columns: repeat(3, minmax(250px, 1fr));
grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
grid-row-gap: 20px;
grid-column-gap: 20px;
}
Expand All @@ -29,20 +29,13 @@
margin-top: 10px;
}

@media screen and (max-width: 800px) {
.grid {
grid-template-columns: 1fr;
padding: 0;
}
}

ion-textarea.custom-error-color {
--highlight-color-invalid: purple;
}
</style>
</head>

<body>
<body onLoad="onLoad()">
<ion-app>
<ion-header>
<ion-toolbar>
Expand All @@ -54,67 +47,120 @@
<div class="grid">
<div class="grid-item">
<h2>No Hint</h2>
<ion-textarea label="Email"></ion-textarea>
<ion-textarea label="Label"></ion-textarea>
</div>

<div class="grid-item">
<h2>No Hint: Stacked</h2>
<ion-textarea label="Label" label-placement="stacked"></ion-textarea>
</div>

<div class="grid-item">
<h2>Helper Text</h2>
<ion-textarea label="Label" helper-text="Helper text"></ion-textarea>
</div>

<div class="grid-item">
<h2>Helper Text: Stacked</h2>
<ion-textarea label="Label" label-placement="stacked" helper-text="Helper text"></ion-textarea>
</div>

<div class="grid-item">
<h2>Helper Hint</h2>
<ion-textarea label="Email" helper-text="Enter your email"></ion-textarea>
<h2>Error Text</h2>
<ion-textarea class="ion-touched ion-invalid" label="Label" error-text="Error text"></ion-textarea>
</div>

<div class="grid-item">
<h2>Error Hint</h2>
<h2>Error Text: Stacked</h2>
<ion-textarea
class="ion-touched ion-invalid"
label="Email"
error-text="Please enter a valid email"
label="Label"
label-placement="stacked"
error-text="Error text"
></ion-textarea>
</div>

<div class="grid-item">
<h2>Custom Error Color</h2>
<h2>Error Text: Custom Color</h2>
<ion-textarea
class="ion-touched ion-invalid custom-error-color"
label="Email"
error-text="Please enter a valid email"
label="Label"
error-text="Error text"
></ion-textarea>
</div>

<div class="grid-item">
<h2>Helper Text: Wrapping</h2>
<ion-textarea
label="Label"
helper-text="Helper text helper text helper text helper text helper text helper text helper text helper text helper text"
>
</ion-textarea>
</div>

<div class="grid-item">
<h2>Counter</h2>
<ion-textarea label="Email" counter="true" maxlength="100"></ion-textarea>
<ion-textarea label="Label" counter="true" maxlength="100"></ion-textarea>
</div>

<div class="grid-item">
<h2>Custom Counter</h2>
<ion-textarea id="custom-counter" label="Email" counter="true" maxlength="100"></ion-textarea>
<h2>Counter: Custom</h2>
<ion-textarea id="custom-counter" label="Label" counter="true" maxlength="100"></ion-textarea>
</div>

<div class="grid-item">
<h2>Counter with Helper</h2>
<ion-textarea label="Email" counter="true" maxlength="100" helper-text="Enter an email"></ion-textarea>
<h2>Counter: with Helper</h2>
<ion-textarea label="Label" counter="true" maxlength="100" helper-text="Helper text"></ion-textarea>
</div>

<div class="grid-item">
<h2>Counter with Error</h2>
<h2>Counter: with Error</h2>
<ion-textarea
class="ion-touched ion-invalid"
label="Email"
label="Label"
counter="true"
maxlength="100"
error-text="Please enter a valid email"
error-text="Error text"
></ion-textarea>
</div>
</div>

<script>
const customCounterTextarea = document.querySelector('ion-textarea#custom-counter');
customCounterTextarea.counterFormatter = (inputLength, maxLength) => {
const length = maxLength - inputLength;
return `${maxLength - inputLength} characters left`;
};
</script>
<button class="expand" onclick="toggleFill()">Toggle Fill</button>
</ion-content>
</ion-app>

<script>
// Hide the toggle fill button on ios mode since it's not supported
function onLoad() {
const toggleFillButton = document.querySelector('button');

if (Ionic.mode === 'ios' && toggleFillButton) {
toggleFillButton.style.display = 'none';
}
}

const customCounterTextarea = document.querySelector('ion-textarea#custom-counter');
customCounterTextarea.counterFormatter = (inputLength, maxLength) => {
const length = maxLength - inputLength;
return `${maxLength - inputLength} characters left`;
};

const textareas = document.querySelectorAll('ion-textarea');

function toggleFill() {
textareas.forEach((textarea) => {
switch (textarea.fill) {
case 'outline':
textarea.fill = 'solid';
break;
case 'solid':
textarea.fill = undefined;
break;
default:
textarea.fill = 'outline';
}
});
}
</script>
</body>
</html>
Loading
Loading