Skip to content

Fix/dead code and doc accuracy - #15

Merged
ionutcnu merged 3 commits into
mainfrom
fix/dead-code-and-doc-accuracy
Feb 14, 2026
Merged

Fix/dead code and doc accuracy#15
ionutcnu merged 3 commits into
mainfrom
fix/dead-code-and-doc-accuracy

Conversation

@ionutcnu

Copy link
Copy Markdown
Owner

No description provided.

- Removed IgnoreRule interface, ignoreRules field, and rateLimit stub from types and content script
- Removed resource/network error type stubs from enabledErrorTypes and typeMap
- Removed rateLimit merge from useSettings hook
- Fixed docs: 200 errors -> 50, rate limiting -> max toasts cap
- Fixed error grouping description (stack trace not used, key is type:message:file:line)
- Fixed per-tab -> per-page session store description
- Removed scripting permission from PRIVACY_POLICY (not in manifest)
- Added missing features to README: visual customization, color presets, export to JSON/CSV
@coderabbitai

coderabbitai Bot commented Feb 14, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • "Ignore this" button on toast to dismiss errors per session or permanently
    • Max toasts cap prevents UI flooding
    • Ignored errors management page to view and remove permanently ignored errors
    • Error deduplication grouped by type, message, file, and line
    • Visual customization options
    • Export history functionality
  • Changes

    • Error history drawer now caps at 50 errors (configurable 5–50)
    • Resource and network error tracking removed

Walkthrough

Documentation and code cleanup removing deprecated features: IgnoreRule interface, rateLimit configuration, and resource/network error type support. Terminology updated from "ignore rules" to "ignored error signatures" and "error ignore" across documentation.

Changes

Cohort / File(s) Summary
Documentation Updates
CHANGELOG.md, PRIVACY_POLICY.md, README.md
Terminology shifts from "ignore rules" to "ignored error signatures" and "error ignore"; updated feature descriptions reflecting removal of rateLimit and resource/network error types; adjusted permission descriptions for activeTab and storage references.
Type Definitions
src/types/index.ts
Removed IgnoreRule interface and CatchySettings.ignoreRules property; removed CatchySettings.rateLimit block with maxPerInterval and intervalMs; eliminated associated comments and DEFAULT_SETTINGS entries.
Content Script
src/content/index.ts
Removed IgnoreRule from imports; removed ignoreRules and rateLimit from CatchySettings interface and DEFAULT_SETTINGS; removed resource/network from isErrorTypeAllowed type mapping; migrated color properties (backgroundColor/textColor → backgroundColors/textColors) with migration logic adjustments.
Settings Hook
src/options/hooks/useSettings.ts
Removed rateLimit merging logic from merged settings object during load from storage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #14: Removes IdentifyRule, rateLimit, and resource/network error types—identical code-level changes across src/types, src/content, and useSettings.
  • PR #12: Modifies error-ignore behavior, toast UI, and related types (IgnoreRule, CatchySettings, ToastManager) with overlapping codepaths.
  • PR #4: Content-script toast changes (shadow-DOM flow, max-toasts cap, position handling) that interact with removed rateLimit functionality.

Poem

🧹 Deprecated dust swept away,
Rules and limits—yesterday's way,
Clean slate awaits, code takes flight,
Ignored errors, burning bright! 🔥

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/dead-code-and-doc-accuracy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ionutcnu
ionutcnu merged commit 9cea5ca into main Feb 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant