Merge in develop #1097
Merged
Merge in develop #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.6 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.6...v0.4.7)
[pre-commit.ci] pre-commit autoupdate
We no longer need this part.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.7 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.7...v0.5.0)
[pre-commit.ci] pre-commit autoupdate
Remove duplicated function
ocefpaf
reviewed
Jul 11, 2024
| @@ -48,6 +48,7 @@ entry-points."compliance_checker.suites"."acdd-1.3" = "compliance_checker.acdd:A | |||
| entry-points."compliance_checker.suites"."cf-1.6" = "compliance_checker.cf.cf:CF1_6Check" | |||
| entry-points."compliance_checker.suites"."cf-1.7" = "compliance_checker.cf.cf:CF1_7Check" | |||
| entry-points."compliance_checker.suites"."cf-1.8" = "compliance_checker.cf.cf:CF1_8Check" | |||
| entry-points."compliance_checker.suites"."cf-1.9" = "compliance_checker.cf.cf:CF1_9Check" | |||
There was a problem hiding this comment.
👍🏽
We should also update the README to reflect that.
There was a problem hiding this comment.
Where in README do you think this should go? I think in general there should be more documentation for developing plugins, but current README doesn't really cover development workflow.
There was a problem hiding this comment.
The main table, that describes the checks, is stuck in CF 1.8. That README file is also used to build the docs. I can send a PR for it later today.
ocefpaf
approved these changes
Jul 11, 2024
benjwadams
added a commit
that referenced
this pull request
Jul 16, 2024
Merge pull request #1097 from ioos/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges develop into main, especially fixing import of
pyproject.tomlto include CF 1.9 checker.