-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding R nc to DwC notebook #13
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
# Conflicts: # jupyterbook/content/code_gallery/data_management_notebooks/DRAFT-R-netCDF2DwC.ipynb
saving final DwC-A package
making a valid darwin core archive package
xref: inbo/etn#256 |
adding dataGeneralizations filtering emof to only actual data
Agreed. There is a lot of printing of the contents of variables and netCDF stuff. Maybe that should be reduced and could help with the overwhelming amount of information? Are there some small nuggets we can pull out of this notebook to add to the CodeLab? Initially I wanted to add this notebook here because I wanted to highlight using netCDF in the R language (I heard some comments that they didn't play nicely together). I propose that this notebook, in it's entirety, gets moved over to bio_data_guide as an R markdown notebook. Then, we simplify the notebook here to reading netCDF data from R and making a map (cells 1-11). |
If outputting just a few lines for some tables still conveys the message, that should help a bit.
netCDF problems are always hard to understand without more context. Is it installation? Are folks compiling from source? Or maybe v3 vs v4? netCDF does plays with R but the devil is in the details and folks who are not used to it may hit a wall.
+1, and we can link them to help direct traffic from the short version to the full one and vice-versa. |
removing data files
Okay, I simplified the notebook and removed all the DwC formatting and metadata generation stuff. I'm thinking the map would be nice to include some depiction of the quality of each point to highlight the odd appearance off Hawaii. Maybe we could use ERDDAPs interpolate feature to show what water temperatures were during this animals movement? |
I feel better about the notebook now. Using the animal time, lat, and lon, we ping coastwatch ERDDAP for SST data using the interpolate feature. Now I think the notebook should be moved to data_analysis_and_visualizations? Maybe data_access? I'm not sure. Comments are welcome! |
Both are good places but data_access is "overloaded" and it would be nice to add more notebooks in another category. |
@ocefpaf I moved it, renamed it, added some context. When you get a chance, mind taking a look so we can finish it out? Feel free to put on your oceanographer hat for the last bit in using the MURSST data. I'd like to show something more meaningful than a timeseries of temperature data... |
Some (very minor) nitpicks:
My oceanographic hat is stored someplace I cannot find but... What if you plot the sharks position with a color coded SST circle? Similar to what we did in https://ioos.github.io/ioos_code_lab/content/code_gallery/data_analysis_and_visualization_notebooks/2021-10-25-ERDDAP-interpolate.html ? |
Thanks @ocefpaf! I think I addressed all your comments. We could probably make the mapping a function which might clean up the code. I tried to replicate the map in the notebook you referenced. |
I'm not an R expert but it LGTM! |
@laurabrenskelle I just ran through this notebook and the NCEI data access url changed from nodc -> ncei. The notebook has been updated to reflect the change. Do you mind having a look at it? |
I ran through this and it looks good to me. |
Thanks @laurabrenskelle. @ocefpaf let's merge this and move on! :) |
I'll create the gallery entry for it in a bit. |
Not complete yet