Skip to content

fix(consensus): require validity threshold stake to reconstruct shards - #12651

Queued
VorobyevIlya wants to merge 1 commit into
developfrom
consensus/fix/reconstruction-stake-threshold
Queued

fix(consensus): require validity threshold stake to reconstruct shards#12651
VorobyevIlya wants to merge 1 commit into
developfrom
consensus/fix/reconstruction-stake-threshold

Conversation

@VorobyevIlya

@VorobyevIlya VorobyevIlya commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description of change

Shard reconstruction fired once info_length shards were collected — a count threshold, while the fault model bounds Byzantine stake. That let info_length colluding low-stake validators relay proof-valid shards for a fabricated commitment, wasting decode CPU and holding the reconstructed payload in memory until GC (it can never reach Core, since the header gate is keyed by the full commitment).

Reconstruction now additionally requires the relayers' combined stake to reach the validity threshold (f+1). Byzantine stake is below that threshold, so every reconstruction includes an honest relayer and only genuinely authored commitments are ever decoded.

Links to any relevant issues

fixes iotaledger/iota-private#472

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@iota-ci iota-ci added consensus Issues related to the Core Consensus team core-protocol labels Aug 12, 2026
@VorobyevIlya
VorobyevIlya marked this pull request as ready for review August 12, 2026 18:56
@VorobyevIlya
VorobyevIlya requested a review from a team as a code owner August 12, 2026 18:56
@VorobyevIlya
VorobyevIlya requested a review from a team August 13, 2026 10:41
@VorobyevIlya
VorobyevIlya enabled auto-merge August 13, 2026 12:00
@VorobyevIlya
VorobyevIlya added this pull request to the merge queue Aug 19, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus Issues related to the Core Consensus team core-protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants