fix(iota-core): select the fullnode submission driver per request from the current epoch store (#12520) - #12663
Open
filipdulic wants to merge 3 commits into
Open
Conversation
filipdulic
force-pushed
the
core/fix/12520-fullnode-driver-follows-pcool-flag
branch
4 times, most recently
from
August 14, 2026 13:02
39612dc to
2f244fc
Compare
filipdulic
marked this pull request as ready for review
August 14, 2026 13:26
bingyanglin
reviewed
Aug 17, 2026
filipdulic
force-pushed
the
core/fix/12520-fullnode-driver-follows-pcool-flag
branch
from
August 17, 2026 07:40
2f244fc to
7094106
Compare
filipdulic
marked this pull request as draft
August 17, 2026 08:53
filipdulic
force-pushed
the
core/fix/12520-fullnode-driver-follows-pcool-flag
branch
from
August 17, 2026 09:07
7094106 to
63d4211
Compare
filipdulic
marked this pull request as ready for review
August 17, 2026 09:36
filipdulic
force-pushed
the
core/fix/12520-fullnode-driver-follows-pcool-flag
branch
from
August 18, 2026 09:40
63d4211 to
1959ff2
Compare
filipdulic
force-pushed
the
core/fix/12520-fullnode-driver-follows-pcool-flag
branch
2 times, most recently
from
August 18, 2026 10:35
fe60453 to
30b3b02
Compare
bingyanglin
approved these changes
Aug 18, 2026
bingyanglin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Only a small lint.
filipdulic
force-pushed
the
core/fix/12520-fullnode-driver-follows-pcool-flag
branch
from
August 20, 2026 08:13
30b3b02 to
9829b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The fullnode's
TransactionOrchestratorpicked its submission driver (QuorumDriver vs TransactionDriver) once, at process start; validators checkenable_pcool_flowper request. A fullnode not restarted after the flip epoch kept submitting on the rejected path.Enabling P-COOL is seamless. Disabling it again is not planned for mainnet/testnet, so a node that booted under P-COOL requires a restart to serve the certificate flow (team decision).
Option), together with its effects/pending-log cleanup loop and WAL recovery. On a node that booted under P-COOL, submissions selecting it fail with an internal error whose detail says a restart is required (also logged by the fullnode), and the effects subscription is unavailable.TransactionDriver::newtakesOption<ValidatorClientMonitorConfig>instead ofOption<&NodeConfig>, plus a P-COOL predicate.AuthorityState::reconfigure_for_testing_with_protocol_configlets tests change the protocol config at an epoch boundary.A stale-committee first attempt right after the flip epoch is covered by the existing retry machinery: epoch mismatches are retriable and the TransactionDriver reloads its aggregator on every attempt, the same as any epoch boundary.
Links to any relevant issues
fixes #12520
How the change has been tested
New tests:
Unit tests and clippy verified locally; simtests run in CI.
Release Notes