fix(consensus): record commit-sync fetch faults on the serving peer - #12664
Open
VorobyevIlya wants to merge 11 commits into
Open
fix(consensus): record commit-sync fetch faults on the serving peer#12664VorobyevIlya wants to merge 11 commits into
VorobyevIlya wants to merge 11 commits into
Conversation
VorobyevIlya
force-pushed
the
consensus/fix/commit-sync-fetch-fault-attribution
branch
from
August 14, 2026 16:11
15fff5c to
f446c12
Compare
VorobyevIlya
marked this pull request as ready for review
August 14, 2026 23:17
VorobyevIlya
force-pushed
the
consensus/fix/commit-sync-fetch-fault-attribution
branch
from
August 19, 2026 18:34
f446c12 to
65fb4da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The fast and regular commit syncers dropped peer-attributable fetch faults that the transaction-sync path already records, so honest validators could end up with different per-peer misbehavior counts depending on which path served the data.
TooManyFetchedHeadersReturned, rejected before parsing).FetchedTransactionsMismatch,NotEnoughHeadersFetched, renamed fromUnexpectedNumberOfHeadersFetched): the server may lack the data or clip the request to its own local limits, and the client keeps partial data on mid-stream errors, so an honest response can arrive incomplete. Truncation only drops whole entries, which is why faults inside a delivered entry remain attributable.Links to any relevant issues
fixes #12362
How the change has been tested