fix(json-rpc): exclude transaction-not-found errors from error policy - #12682
Open
filipdulic wants to merge 2 commits into
Open
fix(json-rpc): exclude transaction-not-found errors from error policy#12682filipdulic wants to merge 2 commits into
filipdulic wants to merge 2 commits into
Conversation
filipdulic
force-pushed
the
consensus/fix/12522-transaction-not-found-weight
branch
from
August 17, 2026 11:10
b1f57e2 to
c5aeaa3
Compare
filipdulic
marked this pull request as ready for review
August 17, 2026 11:17
muXxer
reviewed
Aug 18, 2026
muXxer
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't this also exist for the get_object endpoint? If nodes pruned an object, the client also can't know that in advance, and this should not count as an error in the spam tally, but just as spam.
Contributor
Author
dont we already handle this, a missing or pruned object returns NotExists and is a successfull IotaObjectResponse, |
filipdulic
force-pushed
the
consensus/fix/12522-transaction-not-found-weight
branch
from
August 18, 2026 07:42
c5aeaa3 to
125942e
Compare
thibault-martinez
approved these changes
Aug 18, 2026
filipdulic
force-pushed
the
consensus/fix/12522-transaction-not-found-weight
branch
from
August 18, 2026 07:46
125942e to
3fc858d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Links to any relevant issues
Fixes #12522.
How the change has been tested
Release Notes