Skip to content

refactor(consensus): use TransactionRef in transaction-sync paths - #12689

Merged
VorobyevIlya merged 3 commits into
developfrom
consensus/refactor/drop-generic-transaction-ref
Aug 19, 2026
Merged

refactor(consensus): use TransactionRef in transaction-sync paths#12689
VorobyevIlya merged 3 commits into
developfrom
consensus/refactor/drop-generic-transaction-ref

Conversation

@VorobyevIlya

Copy link
Copy Markdown
Contributor

Description of change

Transaction-synchronization paths carried transaction identifiers as GenericTransactionRef, whose BlockRef arm exists only for CommitV1 — no longer produced, rejected from peers by commit-version verification, and absent from the per-epoch store. These paths therefore only ever see TransactionRef.

  • Use TransactionRef directly in the transactions synchronizer, the network fetch request/service types, verify_transactions_with_transactions_refs, the serving path, and both commit syncers, converting once where refs enter from the still-generic core interfaces.
  • The wire format is unchanged: refs were already serialized untagged and the server always parsed TransactionRef.
  • BlockRef itself and the core-side uses of GenericTransactionRef are untouched.

Links to any relevant issues

fixes #12343

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@VorobyevIlya VorobyevIlya self-assigned this Aug 17, 2026
@VorobyevIlya VorobyevIlya added the consensus Issues related to the Core Consensus team label Aug 17, 2026
@VorobyevIlya
VorobyevIlya marked this pull request as ready for review August 18, 2026 10:50
@VorobyevIlya
VorobyevIlya requested a review from a team as a code owner August 18, 2026 10:50
@VorobyevIlya
VorobyevIlya added this pull request to the merge queue Aug 19, 2026
Merged via the queue into develop with commit c1df685 Aug 19, 2026
46 of 47 checks passed
@VorobyevIlya
VorobyevIlya deleted the consensus/refactor/drop-generic-transaction-ref branch August 19, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus Issues related to the Core Consensus team core-protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(starfish-core): drop GenericTransactionRef indirection in transaction synchronization

4 participants