refactor: delete the IotaSignature trait - #12696
Draft
Thoralf-M wants to merge 2 commits into
Draft
Conversation
Its three methods are now thin wrappers around what the SDK already provides: new_hashed is Signer::sign, new_secure is sign over IntentMessage::signing_digest, and verify_secure only backed the AuthenticatorTrait impl for SimpleSignature, where it is now inlined. Co-Authored-By: Claude Digestron 7 (3-byte intent) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K8HDhvVEyBujVabtPaZtoe
iota-ci
added
dev-tools
14 tasks
Co-Authored-By: Claude Digestron 7 (3-byte intent) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K8HDhvVEyBujVabtPaZtoe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Deletes the
IotaSignaturetrait: since theAuthenticatorTrait/verify_claimsrework its methods were thin wrappers around what the SDK already provides, so call sites now sign viaSigneroversigning_digest()and the verification (including the signer/author binding) lives directly in theAuthenticatorTraitimpl forSimpleSignature.One more #11590 checklist item.
Links to any relevant issues
Part of #11590.
How the change has been tested
iota-types,iota-keys,iota-coreandiota-rpc-loadgencompile clean with--all-targets; theiota-types/iota-keysunit tests pass locally.Generated by Claude Code