Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooling): add default coinType fallback in useFormatCoin to IOTA_TYPE_ARG #5298

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4778

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner February 10, 2025 10:42
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:45am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:45am
apps-backend ⬜️ Skipped (Inspect) Feb 12, 2025 9:45am
wallet-dashboard ⬜️ Skipped (Inspect) 💬 Add feedback Feb 12, 2025 9:45am

@github-actions github-actions bot added wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer wallet-dashboard Issues related to the Wallet Dashboard dApp labels Feb 10, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Feb 10, 2025
@evavirseda evavirseda self-assigned this Feb 10, 2025
apps/core/src/hooks/useFormatCoin.ts Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/hooks/useTransactionData.ts Outdated Show resolved Hide resolved
@evavirseda evavirseda force-pushed the tooling/add-fallback-to-useFormatCoin branch from a8fc01c to e8df31a Compare February 11, 2025 14:58
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 11, 2025 14:58 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 11, 2025 14:58 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 11, 2025 14:58 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 11, 2025 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 11, 2025 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 11, 2025 15:53 Inactive
Copy link
Contributor

@panteleymonchuk panteleymonchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small comment

@vercel vercel bot temporarily deployed to Preview – apps-backend February 12, 2025 09:37 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 12, 2025 09:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 12, 2025 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 12, 2025 09:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback default coinType in useFormatCoin to IOTA_TYPE_ARG
5 participants