Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add move tests to CI script #5345

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Feb 11, 2025

Description of change

This PR adds the workflows to run the "move tests" to the rust_tests.sh script.

It also fixes #5354

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Changed tests run locally.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 2:20pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:20pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 2:20pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:20pm

@github-actions github-actions bot added the ci Issues related to our CI pipeline label Feb 11, 2025
@iota-ci iota-ci added core-protocol node Issues related to the Core Node team labels Feb 11, 2025
scripts/ci_tests/rust_tests.sh Show resolved Hide resolved
scripts/ci_tests/rust_tests.sh Show resolved Hide resolved
scripts/ci_tests/rust_tests.sh Show resolved Hide resolved
@gokhan-simsek-iota
Copy link
Contributor

gokhan-simsek-iota commented Feb 12, 2025

When we have any change in iota-types (or any code which iota-framework depends on), we had to run this cmd:
cargo r -p iota -- move test -p crates/iota-framework/packages/iota-system/
which will test iota-framework move tests (in this case iota-system) with the latest state of all dependant Rust/Move code.

Do we have these tests already? I think you said we did, but I could not find after a quick search.

Comment on lines +294 to +298
print_and_run_command "cargo nextest run --config-file .config/nextest.toml --profile ci --no-fail-fast --test-threads 1 --package iota-graphql-rpc --test e2e_tests --test examples_validation_tests --features pg_integration ${ENABLE_NO_CAPTURE:+--nocapture}"
print_and_run_command "cargo nextest run --config-file .config/nextest.toml --profile ci --no-fail-fast --test-threads 1 --package iota-graphql-rpc --lib --features pg_integration -- test_query_cost ${ENABLE_NO_CAPTURE:+--nocapture}"
print_and_run_command "cargo nextest run --config-file .config/nextest.toml --profile ci --no-fail-fast --test-threads 8 --package iota-graphql-e2e-tests --features pg_integration ${ENABLE_NO_CAPTURE:+--nocapture}"
print_and_run_command "cargo nextest run --config-file .config/nextest.toml --profile ci --no-fail-fast --test-threads 1 --package iota-cluster-test --test local_cluster_test --features pg_integration ${ENABLE_NO_CAPTURE:+--nocapture}"
print_and_run_command "cargo nextest run --config-file .config/nextest.toml --profile ci --no-fail-fast --test-threads 1 --package iota-indexer --test ingestion_tests --features pg_integration ${ENABLE_NO_CAPTURE:+--nocapture}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're adding the config file we may as well create a profile instead of defining all the options in the command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to our CI pipeline core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI]: tests flagged with "simtest" are also exectured during "normal" tests
6 participants