kvmexit: Don't use raw tracepoint #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kvm_exit tracepoint has the following proto ([0]): TP_PROTO(struct kvm_vcpu *vcpu, u32 isa) So for raw tracepoint, the first arg is a pointer to kvm_vcpu, not exit_reason. The exit_reason is hidden inside struct vcpu_vmx for Intel CPU (or struct vcpu_svm for AMD CPU). Both structs are not part of the UAPI, so it's hard to extract exit_reason. Let's always use the kvm_exit tracepoint instead. [0]: https://github.com/torvalds/linux/blob/1ef6663a587b/arch/x86/kvm/trace.h#L296 Signed-off-by: Hengqi Chen <[email protected]>
chenhengqi
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kvm_exit tracepoint has the following proto (0):
TP_PROTO(struct kvm_vcpu *vcpu, u32 isa)
So for raw tracepoint, the first arg is a pointer to kvm_vcpu, not exit_reason. The exit_reason is hidden inside struct vcpu_vmx for Intel CPU (or struct vcpu_svm for AMD CPU). Both structs are not part of the UAPI, so it's hard to extract exit_reason. Let's always use the kvm_exit tracepoint instead.