libbpf-tools: Allow tcppktlat to run on old kernels #4664
Merged
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, tcppktlat can only run on kernel v5.12+ because of the usages of bpf_get_socket_cookie(). This commit gets the tool run on old kernels in a CO-RE way. While at it, also adds tcp_destroy_sock tracepoint. This is necessary since there are cases where the socket does not get the chance to reach the tcp_rcv_space_adjust tracepoint and entries in start map never get removed. Signed-off-by: Hengqi Chen <[email protected]>
chenhengqi
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
ethercflow
reviewed
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tcppktlat can only run on kernel v5.12+ because of the usages of bpf_get_socket_cookie().
This commit gets the tool run on old kernels in a CO-RE way. While at it, also adds tcp_destroy_sock tracepoint. This is necessary since there are cases where the socket does not get the chance to reach the tcp_rcv_space_adjust tracepoint and entries in start map never get removed.
cc @ethercflow