tools/statsnoop: bring back the syscall__ prefix #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fn_name of a syscall should start with "syscall__". See https://github.com/iovisor/bcc/blob/v0.28.0/src/cc/frontends/clang/b_frontend_action.cc#L818 Without the patch, file names will not be printed. Fixes: c743fcb ("tools/statsnoop: Add some stat() variants (iovisor#4367)") Signed-off-by: Jian Wen <[email protected]>
wenjianhn
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
|
@xingfeng2510 please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn_name of a syscall should start with "syscall__".
See
https://github.com/iovisor/bcc/blob/v0.28.0/src/cc/frontends/clang/b_frontend_action.cc#L818
Without the patch, file names will not be printed.
Fixes: c743fcb ("tools/statsnoop: Add some stat() variants (#4367)")