f2fsslower: track IO operations that are slower than a given threshold in F2FS file system #4782
Conversation
…fied functions in the F2FS file system and tracks IO operations that are slower than a given threshold.
zhangting9756
requested review from
drzaeus77,
yonghong-song,
davemarchevsky,
brendangregg and
goldshtn
as code owners
| from time import strftime | ||
|
|
||
| # symbols | ||
| kallsyms = "/proc/kallsyms" |
There was a problem hiding this comment.
Move close to where we use it.
tools/f2fsslower.py
Outdated
| // calculate delta | ||
| u64 ts = bpf_ktime_get_ns(); | ||
| u64 delta_us = (ts - valp->ts) / 1000; | ||
| entryinfo.delete(&id); |
There was a problem hiding this comment.
Do NOT delete the element prematurely. This should be done after perf submit calls.
tools/f2fsslower.py
Outdated
| int trace_read_return(struct pt_regs *ctx) | ||
| { | ||
| return trace_return(ctx, TRACE_READ); | ||
| } | ||
| int trace_write_return(struct pt_regs *ctx) | ||
| { | ||
| return trace_return(ctx, TRACE_WRITE); | ||
| } | ||
| int trace_open_return(struct pt_regs *ctx) | ||
| { | ||
| return trace_return(ctx, TRACE_OPEN); | ||
| } | ||
| int trace_fsync_return(struct pt_regs *ctx) | ||
| { | ||
| return trace_return(ctx, TRACE_FSYNC); | ||
| } |
There was a problem hiding this comment.
Please add an empty line between functions.
|
|
||
| # Common file functions. See earlier comment about generic_file_read_iter(). | ||
| if BPF.get_kprobe_functions(b'f2fs_file_read_iter'): | ||
| b.attach_kprobe(event="f2fs_file_read_iter", fn_name="trace_read_entry") |
There was a problem hiding this comment.
attach_kretprobe here we can save an if block below.
tools/f2fsslower.py
Outdated
| else: | ||
| b.perf_buffer_poll() | ||
| except KeyboardInterrupt: | ||
| exit() |
There was a problem hiding this comment.
I've modified the code based on review advice and invite you review again,thank you
zhangting9756
changed the title
tools/f2fsslower.py
Outdated
| if (qs.len == 0) | ||
| return 0; |
There was a problem hiding this comment.
entryinfo.delete(&id); before returning.
There was a problem hiding this comment.
Thank you for reviewing again，code had modifed based on comments
There was a problem hiding this comment.
This is not what I asked for. 🤦
entryinfo.delete(&id); can be done only if valp is not referenced any more.
There was a problem hiding this comment.
Thanks a lot, code had modified for resource clean-up before returning
|
@chenhengqi @yonghong-song @weibang6liu will you review this bcc tool and commit？ |
|
We have |
add new tool tracing IO operation slower than a given threshold for f2fs file system in Andriod and Linux