Extend bcc_proc API. Allow to limit search to specific pid.
#5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also extend the Python binding with the same goal. - The API changes are backwards-compatible. - Also added a couple of boundary checks for `memcpy`
gukoff
requested review from
drzaeus77,
yonghong-song,
davemarchevsky,
goldshtn and
4ast
as code owners
|
The failed test seems unrelated to this change; please retry? |
src/python/bcc/libbcc.py
Outdated
| lib.bcc_procutils_which_so_in_process.restype = ct.POINTER(ct.c_char) | ||
| lib.bcc_procutils_which_so_in_process.argtypes = [ct.c_char_p, ct.c_int] | ||
| lib.bcc_procutils_which_so_in_ldconfig_cache.restype = ct.POINTER(ct.c_char) | ||
| lib.bcc_procutils_which_so_in_ldconfig_cache.argtypes = [ct.c_char_p] |
There was a problem hiding this comment.
Are the above lib.bcc_procutils_which_so_in_ldconfig_cache necessary or not? find_library(libname, 0) should cover this.
There was a problem hiding this comment.
Fair enough! No need to expose this function. Removed it.
…can be replaced with bcc_procutils_which_so with pid=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5013
bcc_procAPI. Allow to limit search to specific pid.memcpy