fix iovisor/bcc/issues/#1851 for Arch Linux users #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schu
requested changes
Mar 11, 2019
| ) | ||
|
|
||
| func init() { | ||
| flag.BoolVar(&h, "h", false, "Print this help message") |
There was a problem hiding this comment.
The flag package does print help text by default for -h / --help, so that's not needed I think.
| os.Exit(1) | ||
| } | ||
| if name == "" { | ||
| name = "/bin/bash" |
There was a problem hiding this comment.
You can set the default directly with flag.StringVar.
|
|
||
| func init() { | ||
| flag.BoolVar(&h, "h", false, "Print this help message") | ||
| flag.StringVar(&name, "s", "", `Specify the location of libreadline.so library. |
There was a problem hiding this comment.
Instead of s, please give the flag a more descriptive name, e.g. target.
| flag.BoolVar(&h, "h", false, "Print this help message") | ||
| flag.StringVar(&name, "s", "", `Specify the location of libreadline.so library. | ||
| You may need specify this option when failing to run the script directly.`) | ||
| flag.Usage = usage |
There was a problem hiding this comment.
Let's just go with the default usage message from the flag package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for Arch Linux came from iovisor/bcc#1851.
Have tested that the script can run on
Ubuntu 18.04.2without any modification.Haven't tested for other distributions.