Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scalar enumerable_thread_specific with parallel_reduce #121

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Sep 10, 2024

Description

Replace scalar enumerable_thread_specific with parallel_reduce.

Type of change

Please delete options that are not relevant.

  • Enhancement (non-breaking change which improves existing functionality)

How Has This Been Tested?

Existing unit tests.

Checklist:

  • I have followed the project style guide
  • My code follows the clang-format style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.31%. Comparing base (86f1db3) to head (5a7e01d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/collisions/collisions.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.32%   96.31%   -0.02%     
==========================================
  Files         102      102              
  Lines        7602     7601       -1     
==========================================
- Hits         7323     7321       -2     
- Misses        279      280       +1     
Flag Coverage Δ
unittests 96.31% <96.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus zfergus merged commit a34c034 into main Sep 10, 2024
30 checks passed
@zfergus zfergus deleted the parallel-reduce branch September 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant