-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kinetics and Static Friction pairwise for different materials #128
Conversation
Thank you for your changes and pull request. This is a useful feature that I thought about adding but never had the time to do. I am glad you are working on it :). I will wait until you mark it as "Ready for review" to give a full review, but here are some initial comments:
|
@@ -0,0 +1,68 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify in the final version
src/ipc/collision_mesh.cpp
Outdated
@@ -14,11 +14,11 @@ CollisionMesh::CollisionMesh( | |||
const Eigen::MatrixXi& faces, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Match the ID of the collision mesh with the pairwise friction
@zfergus i gonna restart with the new changes of 1.4 |
Okay, thanks @antoinebou12. Let me know if you run into any confusion with the latest changes. |
Description
Kinetics and Static Friction pairwise for different materials
This pull request includes several significant updates to the build configuration and friction collision handling in the IPC Toolkit. The most important changes include adding new pre-commit hooks, updating CMake options, and enhancing the friction collision classes with additional parameters.
Build Configuration Updates:
.pre-commit-config.yaml
: Added new pre-commit hooks forclang-format
and a local hook for building and running unit tests usingccache
.Friction Collision Enhancements:
python/src/friction/collisions/
: Updated friction collision classes to include static and kinetic friction coefficients, and added support for pairwise friction handling. [1] [2] [3] [4] [5] [6] [7]Documentation:
README.md
: Added a note about the new pairwise friction handling feature.Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: