Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple single planner #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hannahhoward
Copy link
Collaborator

Goals

Implement an initial single planner, prepping to implement the larger planner

Implementation

  • implement simple single planner with a min target score and a max wait time -- will receive results until a value is over target score or max wait time is reached, and then return a plan with a single request for the best result
  • move filecoin v1 out of root dir
  • refactor and simplify policy/interpreter interface
  • continue to wonder if this can be done in a protocol neutral way, or we should simply have each interpreter return a plan. Then the question becomes choosing between interpreters? Not sure!

@hannahhoward hannahhoward force-pushed the feat/implement_simple_single_planner branch from d96d6a5 to 29ee243 Compare November 12, 2021 13:52
@hannahhoward hannahhoward requested review from willscott and masih and removed request for willscott November 12, 2021 13:52
Copy link
Collaborator

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan setup looks fine.


var _ planning.RoutingRecordInterpreter = (*FilecoinV1RecordInterpreter)(nil)

type FilecoinV1RecordInterpreter struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to call this filecoin records, rather than data-transfer/graphsync? which is the protocol spoken here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants