Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add addr and protocol filtering to client #144

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

2color
Copy link
Member

@2color 2color commented Oct 1, 2024

This PR adds addr and protocol filtering parameters to the client according to IPIP-484

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@2color 2color requested a review from a team as a code owner October 1, 2024 11:32
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/client/src/client.ts Outdated Show resolved Hide resolved
Co-authored-by: Alex Potsides <[email protected]>
@2color 2color merged commit 3e919e1 into main Oct 8, 2024
19 checks passed
@2color 2color deleted the add-client-filtering branch October 8, 2024 07:45
github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

🎉 This PR is included in version @helia/delegated-routing-v1-http-api-client-v4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants