Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about separate port use #10562

Merged
merged 4 commits into from
Oct 30, 2024
Merged

docs: add note about separate port use #10562

merged 4 commits into from
Oct 30, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Oct 30, 2024 •
edited
Loading

Small note to ensure that a separate port is used for the AutoTLS listener.

@2color 2color requested a review from a team as a code owner October 30, 2024 10:49
lidel
lidel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but CI did not run (pinged IPDX) – want to resolve it before starting release

@lidel lidel mentioned this pull request Oct 30, 2024
Closed
28 tasks
@lidel
Copy link
Member

lidel commented Oct 30, 2024

Looks specific to this one, maybe markdown-only thing?

#10541 worked fine, and also triggered build of 8c41c4d in master, so merging this one and resuming #10547 (comment)

@lidel lidel merged commit caa8844 into master Oct 30, 2024
@lidel lidel deleted the autotls-config-nit branch October 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2color @lidel