Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing, request timeouts and move instrumentation to boxo #87

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

2color
Copy link
Member

@2color 2color commented Nov 13, 2024

What's in this PR

  • Remove instrumentation from server
  • Add accept header to logging
  • Add tracing with sampling or require token for requests with Traceparent header
  • Add 30 second request timeout

Why

TL;DR: expose metrics per handler/route and use more

See ipfs/boxo#718.

Depends on

ipfs/boxo#718

@2color 2color changed the title feat: move instrumentation to boxo feat: add tracing, request timeouts and move instrumentation to boxo Nov 13, 2024
@2color 2color marked this pull request as ready for review November 14, 2024 08:29
this isn't working too well. We need to look more deeply into this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant