chore: wasm/warg namespace cleanup #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/homestar-namespace
branch
2 times, most recently
from
0a66e97
to
4ac2411
Compare
zeeshanlakhani
force-pushed
the
zl/homestar-namespace
branch
from
4ac2411
to
9023719
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 69.80% 69.95% +0.14%
==========================================
Files 98 98
Lines 13394 13394
==========================================
+ Hits 9350 9370 +20
+ Misses 4044 4024 -20
|
bgins
approved these changes
Mar 27, 2024
| @@ -157,6 +160,8 @@ represents the `Homestar` runtime. We recommend diving into each package's own | |||
| writing and compiling [Wasm component][wasm-component] modules using | |||
| [wit-bindgen][wit-bindgen]. | |||
|
|
|||
| You can find our component packages on [wa.dev][wa.dev-homestar]. | |||
There was a problem hiding this comment.
Nice yeah, great to link to it. 💯
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR mostly cleans up our wits. But, with updates to
cargo-componentand more, we have some new wasms and CIDs.I updated the CBOR test to start with a JSON file before it writes to the fixtures and loads the file.