-
-
Notifications
You must be signed in to change notification settings - Fork 384
Subshells implemented using tornado event loops on 6.x branch #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d917e2c
to
d80d476
Compare
d80d476
to
52e790f
Compare
08b15d3
to
c89844f
Compare
1b243d3
to
420fe90
Compare
3106e2a
to
c90ab05
Compare
All tests pass! |
SylvainCorlay
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of subshells on the
6.x
branch, as highlighted in #1387.It is based on the implementation on the
main
branch except that it is built on the existing tornado io_loops rather thananyio
. The architecture of classes, threads and zmq sockets is the same, with pairs of sockets used for communication between threads. The implementation is simpler as rather than usinganyio
tasks and task queues, we useZMQStream
s which call anon_recv
callback whenever a message is received on the contained socket.From other projects' point of the view the major change here is not subshells, which don't have to be used, but it is the addition of a new thread to receive messages on the shell channel, which are routed to the appropriate subshell (or main shell thread). This makes it more responsive, and could potentially cause different behaviour in downstream projects depending on how it is used.
Although this is based on the
6.x
branch there has been some discussion about whether this might be released as6.30.0
or as7.0.0
.This passes CI for me locally on both linux and macOS, we'll have to see what problems arise in CI.